Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag entries when subscribing to a feed #183

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Tag entries when subscribing to a feed #183

merged 2 commits into from
Apr 11, 2019

Conversation

qjqqyy
Copy link

@qjqqyy qjqqyy commented Apr 10, 2019 •
edited

image

works for refresh too

If I have the mood tests for subscribe will end up in this PR too no mood... 馃槾

@qjqqyy
FeedUtil: take in Set of Tags
3f51acd
@qjqqyy
feeds/{sub,refresh}: tag entries
b901bf3 
when subscribing to or refreshing a feed we now tag the related entries
with whatever the feed is also tagged with
@qjqqyy qjqqyy added this to the v1.4 milestone Apr 10, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 823

  • 3 of 5 (60.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.864%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/commands/RefreshFeedCommand.java 0 1 0.0%
src/main/java/seedu/address/logic/commands/SubscribeCommand.java 0 1 0.0%
Totals Coverage Status
Change from base Build 796: 0.0%
Covered Lines: 2089
Relevant Lines: 2521
馃挍 - Coveralls

thomastanck
thomastanck approved these changes Apr 11, 2019
View reviewed changes
Copy link

@thomastanck thomastanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qjqqyy qjqqyy merged commit 3b3834c into master Apr 11, 2019
@qjqqyy qjqqyy deleted the feed-tags branch April 11, 2019 08:18
@thomastanck thomastanck modified the milestone: v1.4 Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomastanck thomastanck thomastanck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qjqqyy @coveralls @thomastanck