Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "all" variants of commands #190

Merged
merged 16 commits into from
Apr 14, 2019

Conversation

thomastanck
Copy link

@thomastanck thomastanck commented Apr 14, 2019

Depends on #191.
Resolves #169.

Adds "all" variants such as addall, refreshall, archiveall, etc.

Summary of changes:

  • Refactor DuplicateEntryCommandException to own class so it can be detected during addall operation
  • Add addall and tests
  • Add archiveall and tests
  • Add tests for refresh
  • Add refreshall and tests
  • Add unarchiveall and tests

@coveralls
Copy link

coveralls commented Apr 14, 2019

Pull Request Test Coverage Report for Build 928

  • 107 of 109 (98.17%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.3%) to 91.254%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/commands/CommandResult.java 0 1 0.0%
src/main/java/seedu/address/logic/commands/RefreshAllEntriesCommand.java 21 22 95.45%
Totals Coverage Status
Change from base Build 927: 1.3%
Covered Lines: 2452
Relevant Lines: 2687

💛 - Coveralls

@thomastanck thomastanck force-pushed the all-commands branch 2 times, most recently from 4e57969 to fa61f2a Compare April 14, 2019 05:50
@thomastanck thomastanck force-pushed the all-commands branch 2 times, most recently from e6219cd to c5cff10 Compare April 14, 2019 06:01
@thomastanck thomastanck changed the title [WIP] Add "all" variants of commands Add "all" variants of commands Apr 14, 2019
@thomastanck thomastanck merged commit 5f4ae66 into CS2103-AY1819S2-W10-1:master Apr 14, 2019
@thomastanck thomastanck deleted the all-commands branch April 14, 2019 11:10
@qjqqyy qjqqyy added this to the v1.4 milestone Apr 15, 2019
@thomastanck thomastanck modified the milestone: v1.4 Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refreshing un-downloaded entries should be easier
4 participants