forked from nus-cs2103-AY1819S2/addressbook-level4
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests and remove code to increase coverage #193
Merged
thomastanck
merged 12 commits into
CS2103-AY1819S2-W10-1:master
from
thomastanck:random-tests
Apr 14, 2019
Merged
Add tests and remove code to increase coverage #193
thomastanck
merged 12 commits into
CS2103-AY1819S2-W10-1:master
from
thomastanck:random-tests
Apr 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastanck
force-pushed
the
random-tests
branch
from
April 14, 2019 07:34
b805c4f
to
dc0102a
Compare
thomastanck
changed the title
[WIP] Add more tests to increase coverage
Add tests and remove code to increase coverage
Apr 14, 2019
epicfailname
requested changes
Apr 14, 2019
tests all has*Entry rather than just hasListEntry
epicfailname
approved these changes
Apr 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests over the place to increase coverage.
Also removed unused code to increase coverage.
Summary of changes:
Logic#setViewMode
Logic#setContext
ReaderViewUtil#resolveRelativeLinksToAbsoluteLinks
ReaderViewUtil#createExcerptElement
DateUtil
Logic#executeContextSwitch
, which covers some other methods as wellDeleteArchiveEntryCommand
Model#setArchivesEntryBookFilePath
Model#hasArchivesEntry
,Model#hasFeedsEntry
Model#deleteArchivesEntry
,Model#deleteFeedsEntry
(and its interaction with selected entry)