Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and remove code to increase coverage #193

Merged
merged 12 commits into from
Apr 14, 2019

Conversation

thomastanck
Copy link

@thomastanck thomastanck commented Apr 14, 2019

Some tests over the place to increase coverage.
Also removed unused code to increase coverage.

Summary of changes:

  • Removed unused code:
    • Logic#setViewMode
    • Logic#setContext
    • ReaderViewUtil#resolveRelativeLinksToAbsoluteLinks
    • ReaderViewUtil#createExcerptElement
  • Add tests for:
    • DateUtil
    • Logic#executeContextSwitch, which covers some other methods as well
    • DeleteArchiveEntryCommand
    • Model#setArchivesEntryBookFilePath
    • Model#hasArchivesEntry, Model#hasFeedsEntry
    • Model#deleteArchivesEntry, Model#deleteFeedsEntry (and its interaction with selected entry)

@coveralls
Copy link

coveralls commented Apr 14, 2019

Pull Request Test Coverage Report for Build 926

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.8%) to 90.004%

Totals Coverage Status
Change from base Build 925: 2.8%
Covered Lines: 2323
Relevant Lines: 2581

💛 - Coveralls

@thomastanck thomastanck changed the title [WIP] Add more tests to increase coverage Add tests and remove code to increase coverage Apr 14, 2019
tests all has*Entry rather than just hasListEntry
@thomastanck thomastanck merged commit c8e0643 into CS2103-AY1819S2-W10-1:master Apr 14, 2019
@thomastanck thomastanck deleted the random-tests branch April 14, 2019 11:02
@thomastanck thomastanck added this to the v1.4 milestone Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants