Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network: Follow redirects (up to 15 times) #203

Merged
merged 10 commits into from
Apr 15, 2019
Merged

Network: Follow redirects (up to 15 times) #203

merged 10 commits into from
Apr 15, 2019

Conversation

thomastanck
Copy link

Resolves #174.

Summary of changes:

  • Refactor network to fully use async-http-client
  • Follow redirects

@coveralls
Copy link

coveralls commented Apr 14, 2019 •
edited

Pull Request Test Coverage Report for Build 988

  • 30 of 35 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 91.127%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/util/Network.java 30 35 85.71%
Totals Coverage Status
Change from base Build 987: -0.1%
Covered Lines: 2547
Relevant Lines: 2795
💛 - Coveralls

@qjqqyy
Copy link

qjqqyy commented Apr 15, 2019

Should be good iff tests pass

@thomastanck thomastanck merged commit 99b4563 into CS2103-AY1819S2-W10-1:master Apr 15, 2019
@thomastanck thomastanck deleted the network-follow-redirects branch April 15, 2019 04:06
@thomastanck thomastanck added this to the v1.4 milestone Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qjqqyy qjqqyy qjqqyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Instead of following redirects we save the error page.
3 participants
@thomastanck @coveralls @qjqqyy