Make BrowserPanel load Entry.Link if valid, error page if invalid #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SelectedCardChanged
rlrh
requested review from
thomastanck and
qjqqyy
and removed request for
thomastanck
thomastanck
reviewed
Mar 1, 2019
thomastanck
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves part of #27
When an entry is selected,
BrowserPanelloads its link, or an error page when an error occurs (e.g. no internet, URL invalid).assertEquals(expectedUrl, getBrowserPanel().getLoadedUrl())is removed fromAddressBookSystemTest#assertSelectedCardChangedso thatTypicalEntriesdoes not need to contain valid links, as otherwise an invalid link will result in the loaded URL being the path to error page instead of the expected URL.However,
BrowserPanelTesttests for this correct behaviour when loading a valid and invalid (local) link.