Architectural refactor to move Storage behind Model #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because we want to use the filesystem state as the canonical representation sometimes, i.e. for article storage, which we don't want to store in memory as the articles can be quite large. We could simply expose the Storage to the Model as well, but doing so results in Storage being referenced both from the outside at Logic, and also from the inside whenever articles have to be added. Instead we move the entire Storage behind Model for a cleaner architecture -- now Storage should be an "implementation detail" that the Model uses to persist itself.
qjqqyy
reviewed
Mar 2, 2019
Pull Request Test Coverage Report for Build 152
💛 - Coveralls |
epicfailname
reviewed
Mar 3, 2019
epicfailname
reviewed
Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #22. We need to expose Storage to Model so that pages can be saved.
This is because we want to use the filesystem state as the canonical
representation sometimes, i.e. for article storage, which we don't want
to store in memory as the articles can be quite large.
We could simply expose the Storage to the Model as well, but doing so
results in Storage being referenced both from the outside at Logic,
and also from the inside whenever articles have to be added.
Instead we move the entire Storage behind Model for a cleaner
architecture -- now Storage should be an "implementation detail"
that the Model uses to persist itself.