-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make add command save webpages to disk #39
Make add command save webpages to disk #39
Conversation
b213596
to
fa54a6d
Compare
fa54a6d
to
6f50ea2
Compare
6f50ea2
to
6bcfbf4
Compare
Pull Request Test Coverage Report for Build 168
💛 - Coveralls |
d8329e4
to
c3b42f9
Compare
8e482da
to
20af9ff
Compare
20af9ff
to
f4f476d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work!
Just a question: why do we not store the downloaded files with a .htm
or .html
extension?
@rlrh thanks for the review! I left it out for the moment as that wasn't necessary to meet the requirements and also because I would prefer if the extension on the url matched the extension saved (may not always be .html). It also complicates things when there is no extension. |
Resolves #22.
Next part after this is to allow loading of local webpages into the WebView.
Summary of changes
add
command.