Reading view mode: Basic functionality #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 220
💛 - Coveralls |
|
Test coverage dropped by 0.7% as it is very difficult to test for certain cases. |
thomastanck
reviewed
Mar 11, 2019
| return stateCheck; | ||
| } else { | ||
| return stateCheck && exception.get().getMessage().equals(other.exception.get().getMessage()); | ||
| } |
There was a problem hiding this comment.
It's possible one exception is null but the other isn't.
thomastanck
reviewed
Mar 11, 2019
| return output; | ||
| } | ||
|
|
||
| private static Document convertStringToDocument(String xmlStr) throws Exception { |
There was a problem hiding this comment.
throws Exception do we have a more specific type here?
There was a problem hiding this comment.
There's a couple: javax.xml.parsers.ParserConfigurationException, org.xml.sax.SAXException, java io.IOException
thomastanck
reviewed
Mar 11, 2019
| private ViewMode viewMode; | ||
| private Consumer<CommandResult> onSuccess; |
There was a problem hiding this comment.
We'll merge this for now but note this is why we usually don't want to do any processing on the UI side :p
There was a problem hiding this comment.
The most recent commit doesn't have the CommandResult consumer any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #45
Resolves part of #27
How to use:
view readerfor reading viewview browserfor browser viewHow it works:
When reading view is selected,
BrowserPanelloads the original web page first, then inputs the resulting HTML into Crux for processing, and finally loads the cleaned-up HTML.