Model: When adding Entry, replace empty Title or Description with extracted info #76

rlrh · 2019-03-17T07:09:36Z

Resolves #47

Summary of changes:

Modify AddCommand#execute to replace empty Title or Description with best candidates extracted from given Entry's content
- 1st choice: user input
- 2nd choice: information extracted by processing through Crux
- 3rd choice: information extracted by parsing through Jsoup
- 4th choice: information extracted just from URL
Add new dependency: Apache Commons Text - used for string processing
Add utility methods StringUtil#getFirstNWords and StringUtil#getFirstNWordsWithEllipsis
Add isEmpty method to Title and Description
Add tests for AddCommand's new implementation in AddCommandTest with new entries in TypicalEntries and test files in resources
Add integration tests in AddCommandIntegrationTest

… candidates extracted from Entry content

…del#addEntry

…ntries

coveralls · 2019-03-17T08:12:58Z

Pull Request Test Coverage Report for Build 306

69 of 75 (92.0%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 92.829%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/main/java/seedu/address/commons/util/StringUtil.java	8	10	80.0%
src/main/java/seedu/address/logic/commands/AddCommand.java	50	54	92.59%

Totals
Change from base Build 260:	-0.06%
Covered Lines:	1670
Relevant Lines:	1799

💛 - Coveralls

src/test/java/seedu/address/testutil/TypicalEntries.java

src/main/java/seedu/address/model/ModelManager.java

src/test/java/seedu/address/model/ModelManagerTest.java

src/main/java/seedu/address/model/ModelManager.java

… AddCommandIntegrationTest

src/main/java/seedu/address/commons/util/StringUtil.java

epicfailname

LGTM!

rlrh added 12 commits March 16, 2019 19:48

Add isEmpty method to Title and Description

6c0192e

Modify Model#addEntry to replace empty Title or Description with best…

447fc45

… candidates extracted from Entry content

Update AddCommand to accept returned updated Entry

75e160d

Add Apache Commons Text dependency

ea71b51

Add StringUtil#getFirstNWords

534c227

Refine implementation of Model#addEntry

01f3aa7

Update existing tests

66bbce8

Add methods to check for containing of equal entry

2822ed1

Add tests for Model#addEntry new implementation to ModelManagerTest

2d22424

Add another fallback replacement for empty title or description to Mo…

0077a79

…del#addEntry

Add additional test cases in ModelManagerTest and entries in TypicalE…

754b105

…ntries

Add integration tests for AddCommand in AddCommandIntegrationTest

9119006

rlrh added this to the v1.2 milestone Mar 17, 2019

rlrh self-assigned this Mar 17, 2019

rlrh force-pushed the add-entry-crux branch from ae3e7ef to 1e640fa Compare March 17, 2019 08:06

Remove trailing whitespaces from test HTML files

45fca4c

rlrh force-pushed the add-entry-crux branch from 1e640fa to 45fca4c Compare March 17, 2019 08:07

rlrh requested a review from epicfailname March 17, 2019 08:08

epicfailname reviewed Mar 17, 2019

View reviewed changes

qjqqyy reviewed Mar 17, 2019

View reviewed changes

src/main/java/seedu/address/model/ModelManager.java Outdated Show resolved Hide resolved

rlrh and others added 2 commits March 18, 2019 20:21

Refactor Model#addEntry

19d34a7

Refactor extraction logic from Model#addEntry to AddCommand

eebc557

thomastanck force-pushed the add-entry-crux branch from 22b5107 to eebc557 Compare March 18, 2019 12:49

thomastanck and others added 3 commits March 18, 2019 20:57

Remove now irrelevant integration tests

7928390

Migrate unit tests from ModelManagerTest to AddCommandTest and update…

c52694e

… AddCommandIntegrationTest

Remove unused code

bf6b79d

thomastanck reviewed Mar 18, 2019

View reviewed changes

src/main/java/seedu/address/commons/util/StringUtil.java Outdated Show resolved Hide resolved

rlrh changed the title ~~Model: When adding Entry, fill in missing fields by extracting information from its content~~ Model: When adding Entry, replace empty Title or Description with extracted info Mar 19, 2019

Fix logic error in StringUtil#getFirstNWordsWithEllipsis

0576fbd

epicfailname approved these changes Mar 19, 2019

View reviewed changes

rlrh merged commit e8d8240 into CS2103-AY1819S2-W10-1:master Mar 19, 2019

thomastanck mentioned this pull request Mar 19, 2019

As a user, I can add a link with title, description and other helpful metadata automatically extracted #46

Closed

rlrh deleted the add-entry-crux branch March 19, 2019 16:10

rlrh mentioned this pull request Apr 2, 2019

[Depends on #113] Refactor AddCommand #116

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Model: When adding Entry, replace empty Title or Description with extracted info #76

Model: When adding Entry, replace empty Title or Description with extracted info #76

rlrh commented Mar 17, 2019 •

edited

coveralls commented Mar 17, 2019 •

edited

epicfailname left a comment

Model: When adding Entry, replace empty Title or Description with extracted info #76

Model: When adding Entry, replace empty Title or Description with extracted info #76

Conversation

rlrh commented Mar 17, 2019 • edited

Summary of changes:

coveralls commented Mar 17, 2019 • edited

Pull Request Test Coverage Report for Build 306

💛 - Coveralls

epicfailname left a comment

Choose a reason for hiding this comment

rlrh commented Mar 17, 2019 •

edited

coveralls commented Mar 17, 2019 •

edited