Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BrowserPanel#displayReader test #98

Merged
merged 10 commits into from
Mar 27, 2019
Merged

Fix BrowserPanel#displayReader test #98

merged 10 commits into from
Mar 27, 2019

Conversation

rlrh
Copy link

@rlrh rlrh commented Mar 22, 2019

Resolves #97

Summary of changes:

  • Add new local placeholder image used to replace remote images
  • Remove all remote resources (but not links) from Wikipedia test page
  • Add new HTML5 test page without remote resources
  • Add new entry in TypicalEntries for new test page
  • Refactor BrowserPanelTest#displayReader and add new test for reader view on new test entry

@rlrh rlrh added this to the v1.3 milestone Mar 22, 2019
@rlrh rlrh changed the title Fix display reader test Fix BrowserPanel#displayReader test Mar 22, 2019
@coveralls
Copy link

coveralls commented Mar 22, 2019 •
edited

Pull Request Test Coverage Report for Build 412

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.727%
Totals Coverage Status
Change from base Build 411: 0.0%
Covered Lines: 1785
Relevant Lines: 1925
💛 - Coveralls

thomastanck
thomastanck reviewed Mar 24, 2019
View reviewed changes
Copy link

@thomastanck thomastanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix. I would try to minimise the diff on the HTML page but I think the autoformatter kicked in.

src/test/resources/view/BrowserPanelTest/test.html Show resolved Hide resolved
epicfailname
epicfailname approved these changes Mar 26, 2019
View reviewed changes
Copy link

@epicfailname epicfailname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlrh rlrh merged commit 6ab0079 into CS2103-AY1819S2-W10-1:master Mar 27, 2019
@rlrh rlrh deleted the fix-display-reader-test branch March 27, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomastanck thomastanck thomastanck left review comments

@epicfailname epicfailname epicfailname approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rlrh @coveralls @thomastanck @epicfailname