Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SortCommand & SortCommandTest #39

Merged
merged 2 commits into from
Mar 11, 2019
Merged

Add SortCommand & SortCommandTest #39

merged 2 commits into from
Mar 11, 2019

Conversation

bendymochi
Copy link

No description provided.

@bendymochi bendymochi added type.Enhancement An enhancement to an existing story priority.Medium type.Story A user story v1.2 labels Mar 10, 2019
@bendymochi bendymochi added this to the v1.2 milestone Mar 10, 2019
@racheltanxueqi
Copy link

Look goods. Can we try to resolve the coveralls thing? seems like its occurring quite often moving forward.

dukesun99
dukesun99 approved these changes Mar 10, 2019
View reviewed changes
Copy link

@dukesun99 dukesun99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please add function to sort more fields as well.

@bendymochi bendymochi merged commit 8ea401a into master Mar 11, 2019
@racheltanxueqi
Copy link

racheltanxueqi commented Mar 11, 2019 •
edited

Hi @bendymochi, i think we should try to add more testings to let the coverage test or it will keep decreasing next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dukesun99 dukesun99 dukesun99 approved these changes

@racheltanxueqi racheltanxueqi Awaiting requested review from racheltanxueqi

@LiuXuanIan LiuXuanIan Awaiting requested review from LiuXuanIan

Assignees
No one assigned
Labels
priority.Medium type.Enhancement An enhancement to an existing story type.Story A user story v1.2
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bendymochi @racheltanxueqi @dukesun99