Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FilterCommand #52

Merged
merged 5 commits into from
Mar 12, 2019
Merged

Add FilterCommand #52

merged 5 commits into from
Mar 12, 2019

Conversation

bendymochi
Copy link

No description provided.

@bendymochi bendymochi added this to the v1.2 milestone Mar 12, 2019
@LiuXuanIan
Copy link

Great. A lot of work done. Maybe can consider adding FilterCommandTest file.

racheltanxueqi
racheltanxueqi reviewed Mar 12, 2019
View reviewed changes
Copy link

@racheltanxueqi racheltanxueqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! No problem this time! Consider adding javadoc, maybe it will improve coverage :)

@racheltanxueqi
Copy link

Looks good i will merge them now.

@racheltanxueqi racheltanxueqi merged commit 04be11d into master Mar 12, 2019
@bendymochi bendymochi added the type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new label Mar 15, 2019
@bendymochi bendymochi self-assigned this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@racheltanxueqi racheltanxueqi racheltanxueqi left review comments

@dukesun99 dukesun99 Awaiting requested review from dukesun99

@LiuXuanIan LiuXuanIan Awaiting requested review from LiuXuanIan

Assignees

@bendymochi bendymochi

Labels
priority.High type.Story A user story type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new v1.2
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bendymochi @LiuXuanIan @racheltanxueqi