Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilterCommand to filter by multiple fields & refactor person to equipment #60

Merged
merged 5 commits into from
Mar 19, 2019
Merged

FilterCommand to filter by multiple fields & refactor person to equipment #60

merged 5 commits into from
Mar 19, 2019

Conversation

bendymochi
Copy link

Will add more tests soon

@bendymochi bendymochi added priority.High documentation Label for documentation update type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new type.Story A user story v1.2 labels Mar 19, 2019
@bendymochi bendymochi added this to the v1.2 milestone Mar 19, 2019
@bendymochi bendymochi self-assigned this Mar 19, 2019
@bendymochi bendymochi closed this Mar 19, 2019
@bendymochi bendymochi reopened this Mar 19, 2019
racheltanxueqi
racheltanxueqi reviewed Mar 19, 2019
View reviewed changes
Copy link

@racheltanxueqi racheltanxueqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! you tagged it as documentation but have u update the userguide/developerguide?

@racheltanxueqi racheltanxueqi merged commit 59fef30 into master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@racheltanxueqi racheltanxueqi racheltanxueqi left review comments

@dukesun99 dukesun99 Awaiting requested review from dukesun99

@LiuXuanIan LiuXuanIan Awaiting requested review from LiuXuanIan

Assignees

@bendymochi bendymochi

Labels
documentation Label for documentation update priority.High type.Story A user story type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new v1.2
Projects
Schedule
  
Awaiting triage
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bendymochi @racheltanxueqi