Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify SortCommand to support specific fields #75

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Modify SortCommand to support specific fields #75

merged 3 commits into from
Mar 25, 2019

Conversation

bendymochi
Copy link

Supports

  • sort address
  • sort phone
  • sort email
    By default, will sort by name. (Have yet to touch on serial number)

@bendymochi bendymochi added this to the v1.3 milestone Mar 25, 2019
@bendymochi bendymochi self-assigned this Mar 25, 2019
@bendymochi bendymochi added priority.Medium status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new labels Mar 25, 2019
@bendymochi bendymochi closed this Mar 25, 2019
@bendymochi bendymochi reopened this Mar 25, 2019
@bendymochi bendymochi added the documentation Label for documentation update label Mar 25, 2019
racheltanxueqi
racheltanxueqi reviewed Mar 25, 2019
View reviewed changes
Copy link

@racheltanxueqi racheltanxueqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per what we discussed, good! thanks meiyen

@racheltanxueqi racheltanxueqi merged commit 2dbe224 into master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@racheltanxueqi racheltanxueqi racheltanxueqi left review comments

@dukesun99 dukesun99 Awaiting requested review from dukesun99

@LiuXuanIan LiuXuanIan Awaiting requested review from LiuXuanIan

Assignees

@bendymochi bendymochi

Labels
documentation Label for documentation update priority.Medium status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new v1.3
Projects
Schedule
  
Awaiting triage
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bendymochi @racheltanxueqi