Add tests for RecycleBin, Remove Outdated AddressBook Files #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moved the restore command to function on the deleted list (recycle bin) which is an improvement in functionality. Supporting tests and documentation have also been added and verified. |
|
minor check style issue. I think you can remove the ignore import for the parser util test since there is no more ignores inside that test file. |
ToonDragon
approved these changes
Apr 13, 2019
case141
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmptyBinCommandTestExitBinCommandTestRecycleBinCommandTestwith completed test functionalityRestoreCommandTestwhich is still currently in progressrestorecommand from SourceManagerParser (added from PR Update for Biblio related features #217) as it should now only be supported in RecycleBinParserImplements #226
Partially Implements #215