Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for BiblioEditCommand #227

Merged
merged 25 commits into from
Apr 15, 2019

Conversation

DoItTomorrow
Copy link

@DoItTomorrow DoItTomorrow commented Apr 13, 2019

Updated Default sources to have more fields that are filled.
Updated Sample sources to match test TypicalSources

@ToonDragon
Copy link

Looking at the failed tests, it seems like the typical sources have not been updated appropriately. Perhaps you can check if the biblio fields in the typical sources have been accounted for in the .equals() override command (I had a similar problem for author but rectified it relatively easily).

Can also check the typical sources file itself and see if the bibilo fields have been entered accurately. If they are not correct then the parser will not work properly and cause it to fail.

Copy link

@ToonDragon ToonDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional test functionality for the biblio edit command. One of the test is set to @ignore due to unforeseen circumstances involving test interaction.

Approved for now but will need to see if the test can be rectified in the future (by future i mean tomorrow).

@DoItTomorrow DoItTomorrow merged commit d91fd3e into CS2103-AY1819S2-W13-3:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants