Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Undo command not being able to undo add or order #235

Closed
ToonDragon opened this issue Apr 14, 2019 · 1 comment
Closed

Issue with Undo command not being able to undo add or order #235

ToonDragon opened this issue Apr 14, 2019 · 1 comment
Assignees
Labels
severity.Medium Occasionally causes inconvenience type.Bug Something that isn't working properly
Milestone

Comments

@ToonDragon
Copy link

When trying to undo and add or order command, the command indicates there are no commands to undo despite the counter being stated as one.

Noticed the issue was related to the undo command checking if both the current source manager and the deleted source manager (for the recycle bin functionality) were both being checked at once.

image

If either check failed, the undo command would fail stating that no commands were available to undo. Add and order commands do not commit to the deleted source manager and thus will always trigger this condition.

Perhaps implementing an AND condition would help to solve the issue by making sure that only when both checks for commands failed, then the undo command would fail.

@ToonDragon ToonDragon added type.Bug Something that isn't working properly severity.Medium Occasionally causes inconvenience labels Apr 14, 2019
@ToonDragon ToonDragon added this to the v1.4 milestone Apr 14, 2019
@case141
Copy link

case141 commented Apr 14, 2019

Added an AND condition and also additional checks so that the undo and redo commands will not bug out if the commands only interacts with either the Source Manager or Deleted Sources. #234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity.Medium Occasionally causes inconvenience type.Bug Something that isn't working properly
Projects
None yet
Development

No branches or pull requests

2 participants