Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed undo redo bug and Completed Tests for Recycle Bin #234

Merged
merged 17 commits into from
Apr 14, 2019

Conversation

case141
Copy link

@case141 case141 commented Apr 14, 2019

  • previously undo and redo bugged out when the model only interacts with the sourcemanager side and not the deletedsources side, therefore I introduced an if condition to check for this case and manage accordingly
  • remove @ignore from tests in EditCommandTest that were previously failing because of undo redo
  • completed writing of tests for Recycle Bin'
  • added code for generation of sampleDeletedData.json

#235 #215

@case141 case141 changed the title Fixed undo redo bug and Added more Tests Fixed undo redo bug and Completed Tests for Recycle Bin Apr 14, 2019
@suriruhani suriruhani merged commit 75c3a7a into CS2103-AY1819S2-W13-3:master Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants