Massive improvement to source model #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from Main 8/3/2019
Source model can now be tested with three basic functions: add - which adds a new source to the database delete - which deletes a source by index list - which lists all the sources currently in the database Database will also load saved sources and automatically save when the exit command is entered Added a user menu for development purposes You can now enter an operation mode to select which app to test: 1 - for the standard address book 4 2 - to test the new model
|
The abstraction for the individual items in the source object have been added but was not included in this latest version of the model. As it is, the extra abstraction feels unnecessary since it is just an object with a string inside. |
DoItTomorrow
approved these changes
Mar 9, 2019
fterh
reviewed
Mar 9, 2019
|
|
||
| switch (input) { | ||
| case "1": | ||
| System.out.println("Starting Addressbook 4."); |
There was a problem hiding this comment.
You should extract these strings out as constants and put them at the top of the file
| + "list\n" | ||
| + "exit\n"); | ||
|
|
||
| boolean loopCondition = true; |
There was a problem hiding this comment.
Maybe name it more descriptively than loopCondition?
| + "exit\n"); | ||
|
|
||
| boolean loopCondition = true; | ||
| while (loopCondition == true) { |
| @@ -29,6 +33,9 @@ public void deleteSourceAtIndex (int index) { | |||
| public void deleteAllSources () { | |||
| database.clear(); | |||
| } | |||
| public Source getSourceAtIndex (int index) { | |||
| return database.get(index); | |||
There was a problem hiding this comment.
You're not handling IndexOutOfBoundsException!!!
src/main/java/seedu/address/sourcemodel/SourceDatabaseCoordinationCenter.java
Outdated
Show resolved
Hide resolved
| case "add": | ||
| // Check size of array (in case user enters "add" and nothing else) | ||
| if (orderSplit.length < 2) { | ||
| System.out.println("Invalid command parameters.\n" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source model can now be tested with three basic functions:
add - which adds a new source to the database
delete - which deletes a source by index
list - which lists all the sources currently in the database
Database will also load saved sources and automatically save when the exit command is entered
Added a user menu for development purposes
You can now enter an operation mode to select which app to test:
1 - for the standard address book 4
2 - to test the new model
#68