forked from nus-cs2103-AY1819S2/addressbook-level4
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add appointment functionality and modify files to account for it #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class is incomplete, regex not filled out
need to add parser still....
refactored version, need to make it suitable
add Prefix to CliSyntax
add example in addaptcommand, corrected bucks in addallcommand
only 2 tests failing
prev commit was a mistake
- add and corrected apt related prefixes across repo - remove allergy from patient requirenonnull - account for appointment in parser tests - added space for descriptor builders when apt/ or y/ is null so that we don't get y/apt - modified typical patients to account for appointments - account for appointment in systemtests (add and edit)
still one error in remallcommandtest
wfxronald
approved these changes
Apr 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will approve first, do resolve all the issues before merging
src/test/data/JsonSerializableGiatrosBookTest/typicalPatientsGiatrosBook.json
Show resolved
Hide resolved
src/test/java/seedu/giatros/logic/commands/EditCommandTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.