Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some AB4 classes and remove some unused attributes #336

Merged
merged 19 commits into from
Apr 7, 2019
Merged

Remove some AB4 classes and remove some unused attributes #336

merged 19 commits into from
Apr 7, 2019

Conversation

s-tr
Copy link

@s-tr s-tr commented Apr 7, 2019

Remove the following unused attributes:

  • Remove Tags from Cell
  • Remove has/delete/setPerson from MapGrid and Model
  • Remove addPerson from Model
  • Remove get/setSelectedPerson, get/setFilteredPersonList from Model

Remove the following unused classes:

  • PersonCard
  • ClearCommand
  • BrowserPanel
  • VersionedMapGrid

s-tr added 19 commits April 7, 2019 13:05
@s-tr
Remove PersonCard
e969c14
@s-tr
Removing references to Person: Remove Tags from Cell
d14992c
@s-tr
Removing references to Person: Remove hasPerson from MapGrid
7537021
@s-tr
Removing references to Person: Remove deletePerson from MapGrid
94e0155
@s-tr
Removing references to Person: Remove setPerson from MapGrid
efc1f4b
@s-tr
Removing unused commands: Remove ClearCommand
0c4fb5d
@s-tr
Removing references to AddressBook: Remove VersionedMapGrid
98bdf50
@s-tr
Removing references to Person: Remove addPerson from Model but not Ma…
8b5b92d 
…pGrid
@s-tr
Removing references to Person: Remove get/setSelectedPerson(), select…
50229e2 
…edPersonProperty() from Model
@s-tr
Removing references to Person: Remove get/updateFilteredPersonList() …
ebb32b9 
…from Model
@s-tr
Removing references to Person: Remove unneeded private methods/variab…
4d2adfa 
…les from ModelManager
@s-tr
Removing references to Person: Remove Name predicate
f0f6f50
@s-tr
Removing references to AddressBook: Remove setAddressBook from Model
c72e15a
@s-tr
Removing references to AddressBook: Remove getAddressBook from Model
446c1dd
@s-tr
Removing references to AddressBook: remove Phone, Email, Address parsers
b95bdd3
@s-tr
Removing references to Person: remove getEmptyMapGrid() from TypicalP…
8d01a89 
…ersons (part of refactoring it out)
@s-tr
Removing references to AddressBook: Remove BrowserPanel
016ff53
@s-tr
Removing references to AddressBook: Remove unused data from CommandTe…
8b679e1 
…stUtil
@s-tr
Fix unused imports
123b820
@s-tr s-tr merged commit 307ed03 into master Apr 7, 2019
@s-tr s-tr added this to the v1.4 milestone Apr 7, 2019
@s-tr s-tr deleted the remove-ab4-classes branch April 10, 2019 07:44
@iwle iwle mentioned this pull request Apr 10, 2019
Merged
@s-tr s-tr mentioned this pull request Apr 12, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@s-tr