Update tests for ListTagsCommand #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused InsufficientBattleshipException.
Add logging capabilities to BoundaryValueChecker.
Change logger.fine to logger.info in Battleship, Orientation, Coordinates, and Tag.
Improve message readability.
Add tests for expected output to user, listing the tags in a user-friendly command result.
bos10
reviewed
Apr 12, 2019
bos10
reviewed
Apr 12, 2019
|
Great PR. Coveralls have been increase because of the added tests. Nice job! |
|
Thanks for the review Boston! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #251. Update tests for ListTagsCommand.