Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Player and Fleet Class #53

Closed
wants to merge 2 commits into from
Closed

Add Player and Fleet Class #53

wants to merge 2 commits into from

Conversation

lucydotc
Copy link

@lucydotc lucydotc commented Mar 3, 2019 •
edited

Re submission of #51

Add a Player class
Add a Fleet Class

@lucydotc lucydotc requested a review from a team March 3, 2019 07:36
@lucydotc lucydotc added this to the v1.1 milestone Mar 3, 2019
@iwle iwle changed the title AddPlayerAndFleetClass Add Player and Fleet Class Mar 3, 2019
erjillsison
erjillsison reviewed Mar 3, 2019
View reviewed changes
Copy link

@erjillsison erjillsison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getSize() and getName() are called twice in the respective StringBuilders

@lucydotc lucydotc closed this Mar 4, 2019
@lucydotc lucydotc deleted the AddPlayerAndFleetClass branch March 4, 2019 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erjillsison erjillsison erjillsison left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucydotc @erjillsison