Update tests for model and storage component #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gohyinhao
changed the title
gohyinhao
changed the title
|
There is a checkstyle error on Travis. Please update the code based on those errors |
lim-jiahui
approved these changes
Mar 11, 2019
zht96830
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model Component
Unit Tests for Attributes
Update AmountTest
Add DateTest
Refactor NameTest
Add CategoryTest
Delete EmailTest
Delete AddressTest
Fixed:
ExpenseTest
ExpenseListTest
NameContainsKeywordsPredicateTest
VersionedFinanceTrackerTest
FinanceTrackerTest
UserPrefsTest
ModelManagerTest
Storage Component
Fixed:
JsonAdaptedExpenseTest
JsonSerializableFinanceTrackerTest
JsonFinanceTrackerTest
JsonUserPrefsStorageTest
StorageManagerTest