forked from nus-cs2103-AY1819S2/addressbook-level4
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor expense commands, update tests, UI, DG #174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamessspanggg
commented
Mar 15, 2019
•
edited
edited
- refactor add, edit, delete, clear, list to addexpense, editexpense, deleteexpense, clearexpense, listexpense
- add tests to expense to increase coverage
- update browser panel to display selected expenses
- update browser panel to display categories in terms of images
- update expense list to always display expenses in descending order of date
- refactor tests based on the change in expense listing
- update undo/redo implementation in DG
jamessspanggg
changed the title
Refactor, update tests and UI
Refactor expense commands, update tests, UI
Mar 16, 2019
jhocx
approved these changes
Mar 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! These changes are very useful, makes things clearer too.
gohyinhao
approved these changes
Mar 16, 2019
jamessspanggg
changed the title
Refactor expense commands, update tests, UI
Refactor expense commands, update tests, UI, DG
Mar 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.