Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor expense commands, update tests, UI, DG #174

Merged
merged 11 commits into from
Mar 17, 2019
Merged

Refactor expense commands, update tests, UI, DG #174

merged 11 commits into from
Mar 17, 2019

Conversation

jamessspanggg
Copy link

@jamessspanggg jamessspanggg commented Mar 15, 2019

  • refactor add, edit, delete, clear, list to addexpense, editexpense, deleteexpense, clearexpense, listexpense
  • add tests to expense to increase coverage
  • update browser panel to display selected expenses
  • update browser panel to display categories in terms of images
  • update expense list to always display expenses in descending order of date
  • refactor tests based on the change in expense listing
  • update undo/redo implementation in DG

@jamessspanggg jamessspanggg added this to the v1.2 milestone Mar 15, 2019
@jamessspanggg jamessspanggg changed the title Refactor, update tests and UI Refactor expense commands, update tests, UI Mar 16, 2019
Copy link

@jhocx jhocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! These changes are very useful, makes things clearer too.

@jamessspanggg jamessspanggg changed the title Refactor expense commands, update tests, UI Refactor expense commands, update tests, UI, DG Mar 17, 2019
@jhocx jhocx merged commit fca0ea5 into CS2103-AY1819S2-W15-2:v1.2 Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants