Create RestaurantSummary and display it in the GUI #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 1, 2019 15:50
…s as its placeholder disappearing and the wraptext of the Labels in RestaurantSummaryPanel don't work
…t package instead
weixin-koh
added
priority.Medium
rbth7e5
reviewed
Apr 2, 2019
rbth7e5
reviewed
Apr 2, 2019
| @@ -107,6 +111,7 @@ public Restaurant(Restaurant restaurant, Category category) { | |||
| this.categories = category; | |||
| this.weblink = restaurant.weblink; | |||
| this.openingHours = restaurant.openingHours; | |||
| this.summary = new Summary(restaurant.getReviews()); | |||
| } | |||
|
|
|||
| public Name getName() { | |||
There was a problem hiding this comment.
Instead of using getters, would be better to create a method. For example, it is possible to pass the UI components into a method to set the name values and summary data.
Wklee96
approved these changes
Apr 2, 2019
| .append(" visits"); | ||
| return builder.toString(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Good Work! Since it is a new class, perhaps you can write a summary class test to ensure it is working perfectly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #90