Implement Sort Command to sort Restaurants by Ratings and fix selection of added/edited/deleted Reviews #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
weixin-koh
commented
Apr 9, 2019
weixin-koh
commented
- Allows Sorting of Restaurants by Ratings As a user I can view restaurants ranked by ratings #50
- Performs sort on the Restaurant list in the versionedFoodDiary, so it is undo-able
- Restaurants can be sorted in ascending or descending order
- Sorted list can be filtered to get Restaurants with the top x number of ratings
added 4 commits
April 7, 2019 00:19
…ts sorted according to rating, allow limit tag to filter the top few Restaurants by ratings
weixin-koh
added
type.Story
weixin-koh
changed the title
weixin-koh
added
status.Ongoing
Wklee96
reviewed
Apr 9, 2019
| Predicate<Restaurant> predicateShowLimitedAsc = (r) -> | ||
| r.getSummary().getAvgRating() < ratingBorder; | ||
| model.updateFilteredRestaurantList(predicateShowLimitedAsc); | ||
| } else { |
There was a problem hiding this comment.
there's a few nested if else here, is there a way to change the logic flow so that it is better structured?
https://nus-cs2103-ay1819s2.github.io/cs2103-website/se-book-adapted/chapters/codeQuality.html#avoid-deep-nesting
There was a problem hiding this comment.
Yes you're right! I'll change modify them in my next PR. Thanks for the tip!
Wklee96
approved these changes
Apr 9, 2019
rbth7e5
approved these changes
Apr 9, 2019
…into sortByRatings * 'master' of https://github.com/cs2103-ay1819s2-w17-1/main: (65 commits) updated styling: updated documentation fixed bugs removed name in status bar Added the default review commands to the userguide, as well as a edit default review command (coming in v2.0) checkstyle fixes removed duplicated check removed file prefix as it is not used updated regex lowered event timeout time changed UI diagram updated UserGuide updated developer guide updated docs removed unused static var modified AddDefaultReviewParserTest to take into account new Review constructor, modified the command's .equals to not take into account the timestamp when comparing commands implemented unit test for AddDefaultReviewCommand modified AddDefaultReviewCommand, its constructor now takes in the review itself rather than just the index. modularised AddDefaultReviewCommandParser included coverage made test to display browser with kfc website ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.