Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified implementation of WebUtil methods #150

Merged
merged 39 commits into from
Apr 14, 2019
Merged

Modified implementation of WebUtil methods #150

merged 39 commits into from
Apr 14, 2019

Conversation

Wklee96
Copy link
Collaborator

@Wklee96 Wklee96 commented Apr 11, 2019

  • Allowed users to visit websites with http protocol
  • Reformed methods in WebUtil to remove duplicates

@Wklee96 Wklee96 added type.Enhancement An enhancement to an existing story priority.Low Unlikely to have status.ReadyForReview The PR is ready for review labels Apr 11, 2019
@Wklee96 Wklee96 added this to the v1.4 milestone Apr 11, 2019
@Wklee96 Wklee96 self-assigned this Apr 11, 2019
skpai27
skpai27 approved these changes Apr 12, 2019
View reviewed changes
Copy link
Collaborator

@skpai27 skpai27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job adding support for https protocol and http, so that it supports almost all kinds of websites.

@Wklee96 Wklee96 added status.Ongoing The issue/PR is currently being worked on. note: remove this label before closing an issue. and removed status.ReadyForReview The PR is ready for review labels Apr 13, 2019
@Wklee96
Copy link
Collaborator Author

Wklee96 commented Apr 13, 2019

Will be adding tests for VisitWeb command

@Wklee96
added parser tests for weblink and opening hours
54fda04
@Wklee96
Merge branch 'browserWindow' of https://github.com/Wklee96/main into …
77b7960 
…browserWindow
@Wklee96
refractor code
68ecdde
@Wklee96
ensured visitWebCommand parses the correct msg, and implemented test …
032f680 
…cases
@Wklee96
updated equals method in visitWeb command
aed3771
@Wklee96
added invalid opening hours and weblink for testing
57e4af4
@Wklee96
add in tests for invalid weblink and opening hours for add command
0873154
@Wklee96
added on to addcommand system test
460bd29
@Wklee96
updated edit command system test
77b13e0
@Wklee96
added tests for browser panel
2cbff33
@Wklee96
updated activity diagram
a2ab9aa
@Wklee96
updated PPP
4eb98a5
@Wklee96
updated diagram
dba0160
@Wklee96
updated visitWebUrlSeqDiagram
ab00c89
@Wklee96
updated developer guide
b6cdfc4
@Wklee96
updated user guide with pictures
fd99681
@Wklee96
refractor EditCommand method
ea0bbe6
chanqingzhou
chanqingzhou approved these changes Apr 14, 2019
View reviewed changes
Copy link
Collaborator

@chanqingzhou chanqingzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@Wklee96 Wklee96 merged commit ab986ea into CS2103-AY1819S2-W17-1:master Apr 14, 2019
@Wklee96 Wklee96 deleted the browserWindow branch April 14, 2019 14:24
This was referenced Apr 14, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skpai27 skpai27 skpai27 approved these changes

@chanqingzhou chanqingzhou chanqingzhou approved these changes

Assignees

@Wklee96 Wklee96

Labels
priority.Low Unlikely to have status.Ongoing The issue/PR is currently being worked on. note: remove this label before closing an issue. type.Enhancement An enhancement to an existing story
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Wklee96 @skpai27 @chanqingzhou