Improve UI, add tests and improve documentation #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 13, 2019 14:39
…into sortByRatings * 'master' of https://github.com/cs2103-ay1819s2-w17-1/main: added postal desc to tests removed optional fields failure tests removed tests for optional fields changed restaurant toString to display only non default fields modified Restaurant's toString method to show only non optional logged no internet exception updated UI to not show optional fields changed toString of all optional fields to be empty string made phone and email optional and updated add message make phone and email optional to be added implement dummy placeholder for phone implemented a placeholder for Email
…clude postal code in restaurant summary, add titles to all panels
weixin-koh
added
type.Task
added 8 commits
April 14, 2019 21:12
…, fix some minor errors in DG as well
…into sortByRatings * 'master' of https://github.com/cs2103-ay1819s2-w17-1/main: (61 commits) reduced pages of doc reduced pages hide url in docs typo fix modified DG, minor edits updated UG DG updated with editReview, deleteReview descriptions and implementations add human pause for autocomplete test add autocomplete tests for command box fix style violations add test to categories command to check reviews unchanged refractor EditCommand method updated user guide with pictures updated developer guide updated visitWebUrlSeqDiagram updated diagram Updated UG, DG, PPP, diagrams for addReview, editReview for DG updated PPP updated activity diagram fix grammar errors in PPP ...
weixin-koh
requested review from
rbth7e5 and
Wklee96
and removed request for
rbth7e5
weixin-koh
added
status.ReadyForReview
rbth7e5
approved these changes
Apr 15, 2019
Wklee96
approved these changes
Apr 15, 2019
added 5 commits
April 15, 2019 17:48
…into sortByRatings * 'master' of https://github.com/cs2103-ay1819s2-w17-1/main: manual test case for review commands checkstyle checkstyle for AddReviewCOmmadnParserTest implemented DeleteReviewCommandParserTest Implemented EditReviewCommandParserTest, and minor changes to the EditReviewDescriptorBuilder (removed default values for 0 argument constructor) implemented AddReviewCommandParserTest, modified equals() of AddReviewCommand implemented DeleteReviewCommandtest Implemented EditReviewDescriptorTest editReviewCOmmandTest edit Added tests for EditReviewCOmmand, default values for editReviewDescriptorBuilder, minor changes to UG added default review values to EditReviewDescriptorBuilder added test cases for AddReviewCommandTest, for successful and unsuccessful command execution modified ReviewBuilder final variables to private # Conflicts: # docs/DeveloperGuide.adoc
…into sortByRatings * 'master' of https://github.com/cs2103-ay1819s2-w17-1/main: updated documentation grammar fixed styling errors updated docs updated documents updated documentaions updated doucments updated test cases to work with postal data updated test cases updated implementation # Conflicts: # docs/diagrams/ModelComponentClassDiagram.pptx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.