Show Reviews as a list in the UI #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
weixin-koh
commented
Mar 19, 2019
weixin-koh
commented
- Add ReviewCards and ReviewListPanel to the UI and their Handles to the UI Tests
- Remove v1.1's Reviews as a field in the RestaurantCard
added 6 commits
March 19, 2019 15:41
…into reviewUi * 'master' of https://github.com/cs2103-ay1819s2-w17-1/main: (21 commits) update developer guide to indicate whether supported categories are located update description of restaurant categorisation in developer guide update developer guide to include restaurant categorisation implementation fix style violations fix system test errors due to improper Optional handling update ui to support new categories fix style violations fix updating one category will override other categories update json adapted restaurant to support categories update parser to to parse category update setCategory command field from cuisine to more general category fix style violations replace Cuisine field to more general category field rename cuisine predicate to categorycontainskeywordspredicate initialise category class, move related predicates to categories package initialise occasion class in categories package update message usage for set category command update and generalise set cuisine command to set category command update userguide for setCategory and filter commands updated travis link ...
…into reviewUi * 'master' of https://github.com/cs2103-ay1819s2-w17-1/main: Fixed checkstyle added getAddReviewCommand() to ReviewUtil to reproduce a AddReviewCommand for testing. Also added parseCommand_addReview() into FoodDiaryParserTest as a test case for the AddReview class. added toString() method to AddReview command for debugging modified ReviewBuilder to take timestamp into account. This is so that we can compare Reviews / things requiring reviews properly in the test cases. Added editReview test into ParserTest, fixed EditReviewCommand .equals() method added ReviewUtil for test cases added EditReviewDescriptorBuilder for test cases checkstyle fix editReview command done, no checkstyle wip2, finished EditReviewCommandParser, added message for NoRestaurantSelected wip 1
…into reviewUi * 'master' of https://github.com/cs2103-ay1819s2-w17-1/main: updated default weblink for Amy and Bob debugged. browser panel now loads placeholder instead of blank html modify weblink of test cases to default instead of kfc.com.sg changed sample data changed sampleDataUtil to include https in weblink updated respective test files updated restaurantListPanelTest with https requirement of weblink updated typical restaurant json file updated builder with correct kfc website link updated test files to include https in weblink allowed users to go to website of Restaurant with Goto command created Parser for GotoCommand created skeleton of GotoCommand updated weblink validation to start with http or https allowed users to access weblink of restaurant by clicking on restaurant panel
|
#74 Show Reviews as a list in the UI |
weixin-koh
changed the title
rbth7e5
approved these changes
Mar 19, 2019
weixin-koh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.