forked from nus-cs2103-AY1819S2/addressbook-level4
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.4] Added suggestions commands for common commands and bugfixes #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ream() for DrawTeethUtil.java and InOutAddressBookStorage.java
Update local repo
Update forked repo
Removed preferences.json from gitignore so that the default file will always be saved as TeethHub.json
…es more sense to users. Bugfix: Swapped the error message thrown in isGoTo() and notGoTo() as they were throwing opposite exception messages.
Added missing @OverRide tag to execute() in AddCommand
…ered. Fixed case EditCommand returning new AddCommand() instead of new EditCommand()
Updated messages in Messages.java to be more user friendly.
Added quotation marks to all suggestion commands messages to indicate different command strings.
…ered. Added periods to strings without periods in Messages.java
…electCommand's GOTO_USAGE.
Changed variables and methods that can be package-private to package-private.
Updated SelectCommand to include RecordSelectCommand.
Approved, thank you for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added suggestions commands for common commands. Resolves #173
Added RecordSelect command.
Swapped the error message thrown in isGoTo() and notGoTo() as they were throwing opposite exception messages. Resolves #168
Changed "GoTo mode" to "Records mode" in all messages in Messages.java as they will be shown to the user.
Added missing periods to some messages in Messages.java