Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.4] Added suggestions commands for common commands and bugfixes #180

Merged
merged 33 commits into from
Apr 10, 2019

Conversation

JiaHaoLim
Copy link

@JiaHaoLim JiaHaoLim commented Apr 9, 2019

Added suggestions commands for common commands. Resolves #173
Added RecordSelect command.
Swapped the error message thrown in isGoTo() and notGoTo() as they were throwing opposite exception messages. Resolves #168
Changed "GoTo mode" to "Records mode" in all messages in Messages.java as they will be shown to the user.
Added missing periods to some messages in Messages.java

JiaHaoLim and others added 30 commits April 5, 2019 10:59
…ream() for DrawTeethUtil.java and InOutAddressBookStorage.java
Removed preferences.json from gitignore so that the default file will always be saved as TeethHub.json
…es more sense to users.

Bugfix: Swapped the error message thrown in isGoTo() and notGoTo() as they were throwing opposite exception messages.
…ered.

Fixed case EditCommand returning new AddCommand() instead of new EditCommand()
Updated messages in Messages.java to be more user friendly.
Added quotation marks to all suggestion commands messages to indicate different command strings.
…ered.

Added periods to strings without periods in Messages.java
Changed variables and methods that can be package-private to package-private.
Updated SelectCommand to include RecordSelectCommand.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 52.195% when pulling 7272035 on JiaHaoLim:master into aa61e4d on CS2103-AY1819S2-W17-2:master.

@kthSim
Copy link

kthSim commented Apr 10, 2019

Approved, thank you for the work!

@kthSim kthSim merged commit eb08716 into CS2103-AY1819S2-W17-2:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants