Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.4] Fixes and Test cases #182

Merged
merged 20 commits into from
Apr 10, 2019
Merged

Conversation

JiaHaoLim
Copy link

Changed '' and '/' to File.separator in DrawTeethUtil.java, ParserUtil.java and InOutAddressBook.java.
Updated slash changing loop in ParserUtil.java.
Updated slash changing loop in ParserUtil.java.
Added PdfSerializableAddressBookTest.java.
Added parseOpenSave() tests and parseImportExport() tests to ParserUtilTest.java.
Added OpenCommandParser.java.
Added SaveCommandParser.java.

@coveralls
Copy link

coveralls commented Apr 10, 2019

Coverage Status

Coverage increased (+5.5%) to 59.307% when pulling 2490da5 on JiaHaoLim:master into eb08716 on CS2103-AY1819S2-W17-2:master.

@kthSim
Copy link

kthSim commented Apr 10, 2019

Approved! Thanks for the work!

@kthSim kthSim merged commit d0881ad into CS2103-AY1819S2-W17-2:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants