Change date to not accept future dates #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugeneyl
commented
Apr 11, 2019
eugeneyl
commented
- For spend and edit commands, users can no longer add in future date as the date field.
kjiaxuan
reviewed
Apr 11, 2019
kjiaxuan
reviewed
Apr 11, 2019
| @@ -54,6 +55,9 @@ public static boolean isValidDate(String test) { | |||
| int month = Integer.parseInt(parsedDate[1]); | |||
| int day = Integer.parseInt(parsedDate[0]); | |||
| LocalDate date = LocalDate.of(year, month, day); | |||
| if (date.isAfter(LocalDate.now())) { | |||
| return false; | |||
| } | |||
| } catch (Exception e) { | |||
There was a problem hiding this comment.
LocalDate has a isAfter method defined, so probably no need to write another method below
There was a problem hiding this comment.
I did not add that method so i did not change it or use it. I think @geezlouisee added it because it is used in the summary methods.
|
Need to change TypicalRecords' GIFT's date to a valid date (i think previously should be 2029) need to change default date in RecordBuilder too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.