Changed all instances of person to record #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackimaru96
reviewed
Mar 12, 2019
| } | ||
|
|
||
| /** | ||
| * Creates and returns a {@code Person} with the details of {@code personToEdit} | ||
| * edited with {@code editPersonDescriptor}. | ||
| * Creates and returns a {@code Record} with the details of {@code RecordToEdit} |
There was a problem hiding this comment.
Should be recordToEdit instead of RecordToEdit
| */ | ||
| public void setPersons(List<Person> persons) { | ||
| this.persons.setPersons(persons); | ||
| public void setRecords(List<Record> people) { |
| @@ -26,8 +26,8 @@ | |||
|
|
|||
| private final VersionedAddressBook versionedAddressBook; | |||
| private final UserPrefs userPrefs; | |||
| private final FilteredList<Person> filteredPersons; | |||
| private final SimpleObjectProperty<Person> selectedPerson = new SimpleObjectProperty<>(); | |||
| private final FilteredList<Record> filteredPeople; | |||
There was a problem hiding this comment.
Should name filteredRecords instead of filteredPeople
JeremyLoye
reviewed
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per developerGuide, all instances of
personare changed torecordto change the application from an addressBook to a financeTracker.