Logic: increase command to accept parameters
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge changes from Louis
- Changed IncreaseCommand to accept parameter AMOUNT - Added IncreaseCommandParser to parse `increase` command with parameter - Changed AddressBookParser to accept IncreaseCommandParser
- Changed IncreaseCommandTest for equals method - Changed AddressBookParserTest to test for IncreaseCommand - Reordered tests in AddressBookParserTest lexicographically - Refactored addCommand to spendCommand
Increase command
Jackimaru96
added
type.Enhancement
|
We should take note of cases when the user does not enter the amount up to 2dp in future. |
kjiaxuan
approved these changes
Mar 15, 2019
eugeneyl
reviewed
Mar 15, 2019
There was a problem hiding this comment.
Can update the regex of class amount to restrict entry to 2 only numbers with 2 decimal place.
Reference for future edits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increasecommand with parameters (Amount)