Add Book and BookShelf models #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takuyakanbr
commented
Mar 8, 2018
takuyakanbr
commented
- Add Book and its components
- Add UniqueBookList
- Add BookShelf
- Add unit tests for new classes
takuyakanbr
added
status.completed
qiu-siqi
reviewed
Mar 8, 2018
| } | ||
| } | ||
|
|
||
| //// person-level operations |
|
|
||
| this.bookShelf = new BookShelf(bookShelf); | ||
| this.filteredBooks = new FilteredList<>(this.bookShelf.getBookList()); | ||
| this.addressBook = new AddressBook(); |
There was a problem hiding this comment.
This is needed for now to keep tests from failing
| @Override | ||
| public void deleteBook(Book target) throws BookNotFoundException { | ||
| bookShelf.removeBook(target); | ||
| indicateAddressBookChanged(); |
| public void addBook(Book book) throws DuplicateBookException { | ||
| bookShelf.addBook(book); | ||
| updateFilteredBookList(PREDICATE_SHOW_ALL_BOOKS); | ||
| indicateAddressBookChanged(); |
| requireAllNonNull(target, editedBook); | ||
|
|
||
| bookShelf.updateBook(target, editedBook); | ||
| indicateAddressBookChanged(); |
| } | ||
|
|
||
| @Override | ||
| public String toString() { |
There was a problem hiding this comment.
you mean this looks legit? o_o
| /** | ||
| * Constructs a {@code Category}. | ||
| * | ||
| * @param category A valid category. |
There was a problem hiding this comment.
what does valid even mean here
| /** | ||
| * Constructs a {@code Description}. | ||
| * | ||
| * @param description A valid description. |
There was a problem hiding this comment.
you must love the word valid a lot
| * | ||
| * Supports a minimal set of list operations. | ||
| */ | ||
| public class UniqueBookList implements Iterable<Book> { |
There was a problem hiding this comment.
Not extending UniqueList?
| this.internalList.setAll(replacement.internalList); | ||
| } | ||
|
|
||
| public void setBooks(List<Book> books) throws DuplicateBookException { |
There was a problem hiding this comment.
can replace with Collection
qiu-siqi
approved these changes
Mar 8, 2018
takuyakanbr
added
status.accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.