Redesigned UI #210
Merged
Redesigned UI #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grinnelldennis
requested review from
AlexanderOtavka,
JohnLennon1997,
lequytra and
dongzeye
grinnelldennis
added
the
DO NOT MERGE
grinnelldennis
commented
May 1, 2019
| @@ -14,7 +14,7 @@ def index | |||
| bucket = get_bucket | |||
| @results = all_results.map do |profile| | |||
| { | |||
| :name => profile.last_name + ", " + profile.first_name, | |||
| :name => profile_name(profile), | |||
There was a problem hiding this comment.
Ignore changes in this file, already addressed by another PR
Merged
grinnelldennis
removed
the
DO NOT MERGE
JohnLennon1997
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #206 #193
Changes
Testing
git checkout fix-formattingrails s -b $IP -p $PORTNote
The PR also addresses #203, which is also in a different PR. Ignore that functionality here, and it has been included because other changes have also been made to the users_show
Merge after department/LynBranch