Performance test data #1106
Merged
Performance test data #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opqdonut
reviewed
Apr 10, 2019
| @@ -65,10 +67,20 @@ | |||
| :application/form | |||
| :application/licenses)) | |||
|
|
|||
| (mount/defstate all-applications-cache | |||
| :start (atom {:last-processed-event-id 0 | |||
| :applications nil})) | |||
There was a problem hiding this comment.
core.cache has nice functional caches with various startegies... would they be applicable?
There was a problem hiding this comment.
The events are immutable and the injections are not yet cached in state, so for now an atom is enough. I'll keep core.cache in mind when doing further optimizations.
The following tests are coupled to the amount of test data and would break: rems.migrations.test-convert-to-dynamic-applications/test-migration rems.api.test-catalogue-items/catalogue-items-api-test
opqdonut
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#863
The most critical performance optimizations have been done. More will follow.