Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty deciders 1188 #1199

Merged
merged 3 commits into from May 3, 2019
Merged

Empty deciders 1188 #1199

merged 3 commits into from May 3, 2019

Conversation

hukka
Copy link
Contributor

@hukka hukka commented May 3, 2019

closes #1188

Macroz
Macroz requested changes May 3, 2019
View reviewed changes
src/cljs/rems/actions/request_comment.cljs Outdated Show resolved Hide resolved
src/cljs/rems/actions/request_decision.cljs Outdated Show resolved Hide resolved
@hukka hukka requested a review from Macroz May 3, 2019 09:56
@Macroz Macroz merged commit 706287e into master May 3, 2019
@Macroz Macroz deleted the empty-deciders-1188 branch May 3, 2019 13:48
@mmatthiesencsc mmatthiesencsc mentioned this pull request May 9, 2019
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Macroz Macroz Macroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LBR: Deciders should never be allowed to be empty
2 participants
@hukka @Macroz