Show validation errors to user when creating a new form #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okahilak
force-pushed
the
show-form-validation-errors-to-user
branch
from
dd1897f
to
c647994
Compare
Macroz
requested changes
Jun 4, 2019
| @@ -27,20 +28,32 @@ | |||
| (map key-to-id) | |||
| (str/join "-"))) | |||
|
|
|||
| (defn- get-error [context keys] | |||
| (when (:get-form-errors context) | |||
| (let [form-errors @(rf/subscribe [(:get-form-errors context)])] | |||
There was a problem hiding this comment.
I would prefer that the component contains the subscription and not a random function that gets called. You could give the form-errors as parameters into this fn. In this case the subscription is duplicated into the call sites but at least it's more obvious that the component requires data.
|
|
||
| (fn [{:keys [db]} [_ request]] | ||
| (let [form-errors (validate-form (db ::form) (db :languages))] | ||
| (when (nil-vals? form-errors) |
There was a problem hiding this comment.
I would try to restructure the data so that this condition can be a plain empty?
There was a problem hiding this comment.
Done, good suggestion, I think it's better now
Macroz
approved these changes
Jun 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1292