Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash message improvements, remove modal #1619

Merged
merged 14 commits into from Sep 16, 2019
Merged

Conversation

luontola
Copy link
Contributor

#1580

Definition of Done / Review checklist

Reviewability

  • link to issue

Copy link
Contributor

@okahilak okahilak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, two minor comments.

@luontola luontola merged commit d4d2dba into master Sep 16, 2019
@luontola luontola deleted the flash-message-improvements branch September 16, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants