Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't complain about system prop and env config keys #2999

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

Macroz
Copy link
Collaborator

@Macroz Macroz commented Sep 8, 2022

Fixes #2935.

The keys are automatically passed in, so we shouldn't complain about them.

Checklist for author

Remove items that aren't applicable, check items that are done.

Reviewability

  • Link to issue

Backwards compatibility

  • Config is backwards compatible

Documentation

  • Update changelog if necessary

Testing

  • Complex logic is unit tested (not sure if it's worthwhile)

The keys are automatically passed in, so we shouldn't complain about them.
@Macroz Macroz merged commit f7048c6 into master Sep 8, 2022
@Macroz Macroz deleted the fix-unrecognized-keys branch September 8, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve config merging
2 participants