Create test/demo data by selecting configured languages localizations #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aatkin
changed the title
aatkin
changed the title
aatkin
changed the title
It would be better to use test-data-helpers ns, but a lot of code uses test-helpers so if it is decided to refactor these ns referrals, then it is easier to do mass replace if every place uses the same ns.
aatkin
force-pushed
the
2334/demo-data-languages
branch
from
5a019ad
to
4f68b66
Compare
Macroz
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates #2334
Add logic to
test-data-helpersfunctions to select configured languages for localized fields. Test data creation/generation can pass as many localizations as needed, and the actual localizations are selected based on the current configuration.Also refactored
test-datanamespace to usetest-data-helpersfunctions with namespace prefix (test-helpersas used elsewhere) instead of:all.Checklist for author
Remove items that aren't applicable, check items that are done.
Reviewability
Documentation
Follow-up