Disable email

[Macroz]

Close #3117
Close #3116

Adds two ways of disabling emails. One for handlers completely, one per email type.

Checklist for author

Remove items that aren't applicable, check items that are done.

Reviewability

• Link to issue

Backwards compatibility

• Config is backwards compatible

Documentation

• Update changelog if necessary

Testing

• Complex logic is unit tested
• Valuable features are integration / browser / acceptance tested automatically

[aatkin]

LGTM! One thing to notice is that email API (sending handler/reviewer reminders) is not suppressed by this change. Maybe this could be reflected in the changelog message, or be included as a change in API. Now changelog states that all handler emails can be disabled, which is technically not the case.

[Macroz]

LGTM! One thing to notice is that email API (sending handler/reviewer reminders) is not suppressed by this change. Maybe this could be reflected in the changelog message, or be included as a change in API. Now changelog states that all handler emails can be disabled, which is technically not the case.

I'll improve the text. Reminder mails are not sent unless configured, so they can be disabled with their own config. I think it could make sense to keep the reminders while having other emails disabled still so the current combination is perhaps good.