Refactor test data form fields #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macroz
reviewed
Mar 9, 2023
Macroz
approved these changes
Mar 23, 2023
Test data creates example form with all fields, which contains all normal fields plus special fields that are a combination of normal fields with options. All form fields are now defined separately, and example form with all fields is now more explicit.
aatkin
force-pushed
the
anssi/refactor-test-data
branch
from
ec5e6e7
to
180f712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract test data form fields into separate
(def)s, and make example field groups more explicit (e.g. conditional field with select).Checklist for author
Remove items that aren't applicable, check items that are done.
Follow-up