Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended logging 2 #3199

Merged
merged 9 commits into from
Oct 19, 2023
Merged

Extended logging 2 #3199

merged 9 commits into from
Oct 19, 2023

Conversation

Macroz
Copy link
Collaborator

@Macroz Macroz commented Oct 17, 2023

Continuation of #3187

For #3184

Sample log with third line an example of this new extended logging:

2023-10-16 19:54:40,626 [6b31f9b67c20 rqc:1 owner lGpEJ6Ke] INFO  rems.middleware - req > :post /api/resources/create
2023-10-16 19:54:40,631 [6b31f9b67c20 rqc:1 owner lGpEJ6Ke] INFO  rems.middleware - > :post /api/resources/create lang: :en user: {:userid owner, :name Owner, :email owner@example.com}  roles: #{:logged-in :owner}
2023-10-16 19:54:40,637 [6b31f9b67c20 rqc:1 owner lGpEJ6Ke] INFO  rems.api.resources - > params: {:licenses [], :organization #:organization{:id nbn}, :resid my-res-test}
2023-10-16 19:54:40,640 [6b31f9b67c20 rqc:1 owner lGpEJ6Ke] INFO  rems.middleware - req < :post /api/resources/create 200 14ms

Checklist for author

Remove items that aren't applicable, check items that are done.

Reviewability

  • Link to issue

Documentation

  • Update changelog if necessary (already there)
  • Update docs/ (if applicable)

Testing

  • Valuable features are integration / browser / acceptance tested automatically

Follow-up

Markku Rontu added 6 commits October 13, 2023 15:17
This enabled us to log the calling API namespace and not the utility
namespace.

We don't need to log the `:uri` here necessarily as it is often the
previous log line (standard logging).

Remove text "extended-logging" so this functions better together with
the standard logging (and does not repeat anything).
@Macroz Macroz changed the title Extended logging2 Extended logging 2 Oct 17, 2023
src/clj/rems/api/util.clj Outdated Show resolved Hide resolved
@Macroz Macroz merged commit 429c4bd into master Oct 19, 2023
7 checks passed
@Macroz Macroz deleted the extended-logging2 branch October 19, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants