-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit repeated action clicking #3205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macroz
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good enough to merge (and perhaps click around in dev).
Macroz
approved these changes
Oct 30, 2023
Since function identity can change, using rate limiting wrapper is tricky. Setting timeout is pretty simple to understand, though.
Keepalive for example uses GET, but most fetch requests probably are not something UI buttons should wait for without being explicitly told so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #3204
rems.atoms/rate-limited-button wraps click handler and allows only 1 click every 2 seconds.
perform-action-button
wraps this and additionally subscribes torems.spa/any-pending-request?
to wait until any put/post requests are done. This should prevent repeated clicking which creates duplicate requests to APIrems.actions.*
[accept-licenses add-licenses add-member approve-reject assign-external-id change-applicant change-resources close decide delete invite-decider-reviewer invite-member redact-attachments remove-member request-decision request-review return-action review revoke vote]rems.administration.blacklist
rems.application.*
[save-draft submit copy-as-new]Checklist for author
Remove items that aren't applicable, check items that are done.
Reviewability
Documentation
Follow-up