-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add user mock data #60
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As on discord: the social media links might be changed to handles, we might be adding hobbies, and we might be adding number bedroom and bathroom
But in the meantime, you can address the comments I made :)
src/firebase/data/userData.js
Outdated
couples: false, | ||
}, | ||
maxPropertyPrice: 1200, | ||
maxDistanceToSchool: 1.5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right now the slider for property preference is integer numbers so just make sure the other values for maxDistanceToSchool that have decimals get rounded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
mild request for it to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple more small changes and then good to merge
src/firebase/userDb.js
Outdated
} | ||
|
||
export async function postMockUser() { | ||
console.log("inside mock user"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log("inside mock user"); |
just so that there's no debug statements in main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
src/firebase/data/userData.js
Outdated
numBedroom: "1", | ||
numBathroom: "1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
numBedroom: "1", | |
numBathroom: "1", | |
numBedrooms: "1", | |
numBathrooms: "1", |
the property that we're using in the components is plural
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added user mock data to firestore database
Randomly generate 30 mock users with no profile photos with required fields shown in our database schema doc; post the mock user data to firestore under "users" collection.