Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user mock data #60

Merged
merged 6 commits into from
Mar 6, 2023
Merged

add user mock data #60

merged 6 commits into from
Mar 6, 2023

Conversation

jn1118
Copy link
Contributor

@jn1118 jn1118 commented Mar 3, 2023

Added user mock data to firestore database

Randomly generate 30 mock users with no profile photos with required fields shown in our database schema doc; post the mock user data to firestore under "users" collection.

@vercel
Copy link

vercel bot commented Mar 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
roomie ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 3:19AM (UTC)

Copy link
Contributor

@bjtrieu bjtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As on discord: the social media links might be changed to handles, we might be adding hobbies, and we might be adding number bedroom and bathroom

But in the meantime, you can address the comments I made :)

couples: false,
},
maxPropertyPrice: 1200,
maxDistanceToSchool: 1.5,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now the slider for property preference is integer numbers so just make sure the other values for maxDistanceToSchool that have decimals get rounded

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

src/firebase/data/userData.js Show resolved Hide resolved
@aidandenlinger
Copy link
Contributor

aidandenlinger commented Mar 3, 2023

mild request for it to be lifestyle.smoking instead of lifestyle.smoke, but it's not a big deal either way

Copy link
Contributor

@bjtrieu bjtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple more small changes and then good to merge

}

export async function postMockUser() {
console.log("inside mock user");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log("inside mock user");

just so that there's no debug statements in main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Comment on lines 14 to 15
numBedroom: "1",
numBathroom: "1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
numBedroom: "1",
numBathroom: "1",
numBedrooms: "1",
numBathrooms: "1",

the property that we're using in the components is plural

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

@bjtrieu bjtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jn1118 jn1118 merged commit ca220a8 into main Mar 6, 2023
@jn1118 jn1118 deleted the siax-userdata branch March 6, 2023 03:22
@aidandenlinger aidandenlinger linked an issue Mar 7, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create mock user data
3 participants