Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoplay #126

Closed
chrissly opened this issue Jul 1, 2011 · 6 comments
Closed

Autoplay #126

chrissly opened this issue Jul 1, 2011 · 6 comments

Comments

@chrissly
Copy link

chrissly commented Jul 1, 2011

if autoplay ist disabled, but autoplaylocked and enableNavigation set to true, Autoplay suddenly is turned on after clicking the Navigation.

@Mottie
Copy link
Contributor

Mottie commented Jul 1, 2011

The autoPlayLocked shouldn't be set to true if you have autoPlay set to false. I can force autoPlayLocked to be false internally when autoPlay is false but then you have less control over the slider. So is this a problem?

@chrissly
Copy link
Author

chrissly commented Jul 1, 2011

Well, i guess its no big deal. I just depended on the autoPlay description "this turns off the entire Functionality" and was surprised, as i saw this.
When having parameters, which can be independently set, but actually depend on each other, an internal consistency check would make sense for me. After all, it doesnt really take away functionality, but makes the system more reliable.

@Mottie
Copy link
Contributor

Mottie commented Jul 1, 2011

Cool.. I was going to fix it anyway... darn OCD LOL.

@Mottie
Copy link
Contributor

Mottie commented Jul 5, 2011

Hi Chrissly!

Ok I've actually split out the autoPlay functionality and added buildStartStop like you suggested in another issue. And autoPlayLocked should no longer work when buildStartStop is false.

@Mottie Mottie closed this as completed Jul 6, 2011
@Mottie
Copy link
Contributor

Mottie commented Jul 7, 2011

Hmmm, ok alternate method... I think Helmer has a good point about removing the autoPlay dependancy on the buildStartStop option.

So I separated them and made the autoPlayLocked option false when autoPlay is false - I think that makes more sense.

I just thought I'd let you know about the upcoming change :P

@chrissly
Copy link
Author

Makes more sense, thats true;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants