-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To many !important declarations as an Error? #105
Comments
We only have two designations: warnings and errors. Each instance of !important is a warning and if you have a bunch, it's an error. |
Hmm...maybe its just a mater of semantics, but to me an error is something that will break the CSS. Something like a missing closing bracket, unknown/misspelled attribute name/value, unknown selector. Although to many !important rules are frowned upon it will not break anything if done right. In my case I have a series of quick override classes to zero out margins, padding, borders, rounded corners and another series to float elements left and right and another for text alignment. I use !important on each.
|
I can understand that line of reasoning. There are generally two schools of thought about errors. First is, as you said, a parsing error that will absolutely break if not fixed. The second is that plus "hey, we've warned you a bunch of times and you should be careful about this." I can personally go either way. Nicole, what do you think? |
Okay, we'll change the rollup to a warning from an error. |
Should this be an error or just an alert? Seems like more of an alert to me.
The text was updated successfully, but these errors were encountered: